Remove carve-out in conditional type instantiation that hopefully has been rendered unneeded#51151
Merged
weswigham merged 1 commit intomicrosoft:mainfrom Oct 13, 2022
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50688
This is all good w/ our local test suite, but the extended suite is what matters as, iirc, that's what originally motivated this line. Still, we've changed some other stuff about conditional instantiation since the original change, so hopefully this weird carve-out just isn't needed for compatibility anymore.